Skip to content

Conversation

@pietervdvn
Copy link
Contributor

@pietervdvn pietervdvn commented Jan 28, 2026

Apparently, some people add the edge of platforms into OpenStreetMap.

This was picked up as "railway", giving extra railways renderings where there are none (the two "dead end" railways should dissappear):

image

This PR excludes them from tile generation

Copy link
Collaborator

@migurski migurski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good, really appreciate it. Would you be able to address the linter feedback so it can be merged?

@wipfli
Copy link
Collaborator

wipfli commented Feb 4, 2026

Adding a render test here: pietervdvn#1

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 5, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
75.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@pietervdvn
Copy link
Contributor Author

I've addressed the linter feedback, but, to be a bit blunt: why bother? The tooling can do this fully automatically. IMHO, automatically linting/formatting the codebase every now and then can be done with a script without having to do another round of feedback to me. (For context: I simply made the changes in the web editor without setting up the dev environment)

@pietervdvn
Copy link
Contributor Author

I've also merged (and fixed) in the render test by @wipfli

@bdon
Copy link
Member

bdon commented Feb 6, 2026

The tooling can do this fully automatically. IMHO, automatically linting/formatting the codebase every now and then can be done with a script without having to do another round of feedback to me.

You can run mvn spotless:apply in the tiles directory to do this automatically

@bdon bdon merged commit 60b63bb into protomaps:main Feb 6, 2026
5 of 6 checks passed
bdon added a commit that referenced this pull request Feb 6, 2026
* app: update dependencies

* update CHANGELOG for tiles 4.13.7
@pietervdvn
Copy link
Contributor Author

The tooling can do this fully automatically. IMHO, automatically linting/formatting the codebase every now and then can be done with a script without having to do another round of feedback to me.

You can run mvn spotless:apply in the tiles directory to do this automatically

This implies that I installed the entire toolchain (spoilers: I didn't) and that I know this (spoilers: I didn't). This adds some more friction to the process of contributing here, which IMHO is useless. Just my 2 cents though.

Anyway, thanks for merging in my request and for maintining protomaps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants