-
-
Notifications
You must be signed in to change notification settings - Fork 86
Update Roads.java: exclude 'platform_edge' from railways #547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
migurski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks good, really appreciate it. Would you be able to address the linter feedback so it can be merged?
|
Adding a render test here: pietervdvn#1 |
Add render test for railway platform edge
|
|
I've addressed the linter feedback, but, to be a bit blunt: why bother? The tooling can do this fully automatically. IMHO, automatically linting/formatting the codebase every now and then can be done with a script without having to do another round of feedback to me. (For context: I simply made the changes in the web editor without setting up the dev environment) |
|
I've also merged (and fixed) in the render test by @wipfli |
You can run |
This implies that I installed the entire toolchain (spoilers: I didn't) and that I know this (spoilers: I didn't). This adds some more friction to the process of contributing here, which IMHO is useless. Just my 2 cents though. Anyway, thanks for merging in my request and for maintining protomaps! |


Apparently, some people add the edge of platforms into OpenStreetMap.
This was picked up as "railway", giving extra railways renderings where there are none (the two "dead end" railways should dissappear):
This PR excludes them from tile generation